Commit fb45b2a0 authored by Nikhil Khandelwal's avatar Nikhil Khandelwal Committed by sgrebnov
Browse files

CB-8428 Fix multiple `done()` calls in media plugin test on devices where audio is not configured 

github close #44
parent bae9b8cf

tests/tests.js

+10 −3
Changes for tests/tests.js: 10 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ exports.defineAutoTests = function () { 
        var info = typeof msg == 'undefined' ? 'Unexpected error callback' : msg;

        expect(true).toFailWithMessage(info + '\n' + JSON.stringify(error));

        done();

        this.done = true;

    };



    var succeed = function (done, msg) {
@@ -179,6 +180,7 @@ exports.defineAutoTests = function () { 
        });



        it("media.spec.16 position should be set properly", function (done) {

            var self = this;

            var mediaFile = 'http://cordova.apache.org/downloads/BlueZedEx.mp3',

            mediaState = Media.MEDIA_STOPPED,

            successCallback,
@@ -194,16 +196,19 @@ exports.defineAutoTests = function () { 
                            expect(position).toBeGreaterThan(0.0);

                            media1.stop();

                            media1.release();

                            if (!self.done) {

                                done();

                        }, failed.bind(null, done, 'media1.getCurrentPosition - Error getting media current position'));

                            }

                        }, failed.bind(self, done, 'media1.getCurrentPosition - Error getting media current position'));

                    }, 1000);

                }

            },

            media1 = new Media(mediaFile, successCallback, failed.bind(null, done, 'media1 = new Media - Error creating Media object. Media file: ' + mediaFile), statusChange);

            media1 = new Media(mediaFile, successCallback, failed.bind(self, done, 'media1 = new Media - Error creating Media object. Media file: ' + mediaFile), statusChange);

            media1.play();

        });



        it("media.spec.17 duration should be set properly", function (done) {

            var self = this;

            if (cordova.platformId === 'blackberry10') {

                expect(true).toFailWithMessage('Platform does not supported this feature');

                done();
@@ -222,11 +227,13 @@ exports.defineAutoTests = function () { 
                        expect(media1.getDuration()).toBeGreaterThan(0.0);

                        media1.stop();

                        media1.release();

                        if (!self.done) {

                            done();

                        }

                    }, 1000);

                }

            },

            media1 = new Media(mediaFile, successCallback, failed.bind(null, done, 'media1 = new Media - Error creating Media object. Media file: ' + mediaFile), statusChange);

            media1 = new Media(mediaFile, successCallback, failed.bind(self, done, 'media1 = new Media - Error creating Media object. Media file: ' + mediaFile), statusChange);

            media1.play();

        });

    });