Unverified Commit 639f2bbd authored by Hampton Maxwell's avatar Hampton Maxwell Committed by GitHub
Browse files

Merge pull request #1215 from nfb-onf/master 

Enhanced Fullscreen options for iOS
parents 97604f87 bbf37ed5

README.md

+17 −0
Changes for README.md: 17 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -253,6 +253,8 @@ var styles = StyleSheet.create({ 
* [audioOnly](#audioonly)

* [bufferConfig](#bufferconfig)

* [controls](#controls)

* [fullscreen](#fullscreen)

* [fullscreenOrientation](#fullscreenorientation)

* [headers](#headers)

* [id](#id)

* [ignoreSilentSwitch](#ignoresilentswitch)
@@ -343,6 +345,21 @@ Note on iOS, controls are always shown when in fullscreen mode. 


Platforms: DOM, iOS



#### fullscreen

Controls whether the player enters fullscreen on play.

* **false (default)** - Don't display the video in fullscreen

* **true** - Display the video in fullscreen



Platforms: iOS



#### fullscreenOrientation



* **all (default)** - 

* **landscape**

* **portrait**



Platforms: iOS



#### headers

Pass headers to the HTTP client. Can be used for authorization.

Video.js

+1 −0
Changes for Video.js: 1 added line, 0 removed lines.
Original line number Diff line number Diff line
@@ -354,6 +354,7 @@ Video.propTypes = { 
  controls: PropTypes.bool,

  audioOnly: PropTypes.bool,

  currentTime: PropTypes.number,

  fullscreenOrientation: PropTypes.oneOf(['all','landscape','portrait']),

  progressUpdateInterval: PropTypes.number,

  useTextureView: PropTypes.bool,

  onLoadStart: PropTypes.func,

examples/basic/ios/VideoPlayerTests/Info.plist→examples/basic/ios/VideoPlayer-tvOS.plist

+31 −2
Changes for examples/basic/ios/VideoPlayer-tvOS.plist: 31 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -7,18 +7,47 @@ 
	<key>CFBundleExecutable</key>

	<string>$(EXECUTABLE_NAME)</string>

	<key>CFBundleIdentifier</key>

	<string>org.reactjs.native.example.$(PRODUCT_NAME:rfc1034identifier)</string>

	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>

	<key>CFBundleInfoDictionaryVersion</key>

	<string>6.0</string>

	<key>CFBundleName</key>

	<string>$(PRODUCT_NAME)</string>

	<key>CFBundlePackageType</key>

	<string>BNDL</string>

	<string>APPL</string>

	<key>CFBundleShortVersionString</key>

	<string>1.0</string>

	<key>CFBundleSignature</key>

	<string>????</string>

	<key>CFBundleVersion</key>

	<string>1</string>

	<key>LSRequiresIPhoneOS</key>

	<true/>

	<key>NSAppTransportSecurity</key>

	<dict>

		<key>NSExceptionDomains</key>

		<dict>

			<key>localhost</key>

			<dict>

				<key>NSExceptionAllowsInsecureHTTPLoads</key>

				<true/>

			</dict>

		</dict>

	</dict>

	<key>NSLocationWhenInUseUsageDescription</key>

	<string></string>

	<key>UILaunchStoryboardName</key>

	<string>LaunchScreen</string>

	<key>UIRequiredDeviceCapabilities</key>

	<array>

		<string>armv7</string>

	</array>

	<key>UISupportedInterfaceOrientations</key>

	<array>

		<string>UIInterfaceOrientationPortrait</string>

		<string>UIInterfaceOrientationLandscapeLeft</string>

		<string>UIInterfaceOrientationLandscapeRight</string>

	</array>

	<key>UIViewControllerBasedStatusBarAppearance</key>

	<false/>

</dict>

</plist>

examples/basic/ios/VideoPlayer.xcodeproj/project.pbxproj

+155 −124

File changed.

Preview size limit exceeded, changes collapsed.

examples/basic/ios/VideoPlayer.xcodeproj/xcshareddata/xcschemes/VideoPlayer-tvOS.xcscheme

0 → 100644
+105 −0
Changes for examples/basic/ios/VideoPlayer.xcodeproj/xcshareddata/xcschemes/VideoPlayer-tvOS.xcscheme: 105 added lines, 0 removed lines.
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="UTF-8"?>

<Scheme

   LastUpgradeVersion = "1000"

   version = "1.3">

   <BuildAction

      parallelizeBuildables = "NO"

      buildImplicitDependencies = "YES">

      <BuildActionEntries>

         <BuildActionEntry

            buildForTesting = "YES"

            buildForRunning = "YES"

            buildForProfiling = "YES"

            buildForArchiving = "YES"

            buildForAnalyzing = "YES">

            <BuildableReference

               BuildableIdentifier = "primary"

               BlueprintIdentifier = "2D2A28121D9B038B00D4039D"

               BuildableName = "libReact.a"

               BlueprintName = "React-tvOS"

               ReferencedContainer = "container:../node_modules/react-native/React/React.xcodeproj">

            </BuildableReference>

         </BuildActionEntry>

         <BuildActionEntry

            buildForTesting = "YES"

            buildForRunning = "YES"

            buildForProfiling = "YES"

            buildForArchiving = "YES"

            buildForAnalyzing = "YES">

            <BuildableReference

               BuildableIdentifier = "primary"

               BlueprintIdentifier = "FA8681B6216D5C6D0010C92A"

               BuildableName = "VideoPlayer-tvOS.app"

               BlueprintName = "VideoPlayer-tvOS"

               ReferencedContainer = "container:VideoPlayer.xcodeproj">

            </BuildableReference>

         </BuildActionEntry>

      </BuildActionEntries>

   </BuildAction>

   <TestAction

      buildConfiguration = "Debug"

      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"

      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"

      shouldUseLaunchSchemeArgsEnv = "YES">

      <Testables>

      </Testables>

      <MacroExpansion>

         <BuildableReference

            BuildableIdentifier = "primary"

            BlueprintIdentifier = "FA8681B6216D5C6D0010C92A"

            BuildableName = "VideoPlayer-tvOS.app"

            BlueprintName = "VideoPlayer-tvOS"

            ReferencedContainer = "container:VideoPlayer.xcodeproj">

         </BuildableReference>

      </MacroExpansion>

      <AdditionalOptions>

      </AdditionalOptions>

   </TestAction>

   <LaunchAction

      buildConfiguration = "Debug"

      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"

      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"

      launchStyle = "0"

      useCustomWorkingDirectory = "NO"

      ignoresPersistentStateOnLaunch = "NO"

      debugDocumentVersioning = "YES"

      debugServiceExtension = "internal"

      allowLocationSimulation = "YES">

      <BuildableProductRunnable

         runnableDebuggingMode = "0">

         <BuildableReference

            BuildableIdentifier = "primary"

            BlueprintIdentifier = "FA8681B6216D5C6D0010C92A"

            BuildableName = "VideoPlayer-tvOS.app"

            BlueprintName = "VideoPlayer-tvOS"

            ReferencedContainer = "container:VideoPlayer.xcodeproj">

         </BuildableReference>

      </BuildableProductRunnable>

      <AdditionalOptions>

      </AdditionalOptions>

   </LaunchAction>

   <ProfileAction

      buildConfiguration = "Release"

      shouldUseLaunchSchemeArgsEnv = "YES"

      savedToolIdentifier = ""

      useCustomWorkingDirectory = "NO"

      debugDocumentVersioning = "YES">

      <BuildableProductRunnable

         runnableDebuggingMode = "0">

         <BuildableReference

            BuildableIdentifier = "primary"

            BlueprintIdentifier = "FA8681B6216D5C6D0010C92A"

            BuildableName = "VideoPlayer-tvOS.app"

            BlueprintName = "VideoPlayer-tvOS"

            ReferencedContainer = "container:VideoPlayer.xcodeproj">

         </BuildableReference>

      </BuildableProductRunnable>

   </ProfileAction>

   <AnalyzeAction

      buildConfiguration = "Debug">

   </AnalyzeAction>

   <ArchiveAction

      buildConfiguration = "Release"

      revealArchiveInOrganizer = "YES">

   </ArchiveAction>

</Scheme>