Unverified Commit 6c946d77 authored by Danish's avatar Danish Committed by GitHub
Browse files

little improvement over too many "def" 

just added a function which acts like a ternary with fallback option. Hence, less cluttered "def" variables
great to see that lib is supporting already SDK 27
parent 46d0bc88

android/build.gradle

+8 −12
Changes for android/build.gradle: 8 added lines, 12 removed lines.
Original line number Diff line number Diff line 
apply plugin: 'com.android.library'



def _ext = rootProject.ext



def _reactNativeVersion = _ext.has('reactNative') ? _ext.reactNative : '+'

def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 27

def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '27.0.3'

def _minSdkVersion = _ext.has('minSdkVersion') ? _ext.minSdkVersion : 16

def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 27

def safeExtGet(prop, fallback) {

    rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback

}



android {

    compileSdkVersion _compileSdkVersion

    buildToolsVersion _buildToolsVersion

    compileSdkVersion safeExtGet('compileSdkVersion', 27)

    buildToolsVersion safeExtGet('buildToolsVersion', '27.0.3')



    defaultConfig {

        minSdkVersion _minSdkVersion

        targetSdkVersion _targetSdkVersion

        minSdkVersion safeExtGet('minSdkVersion', 16)

        targetSdkVersion safeExtGet('targetSdkVersion', 27)

        versionCode 1

        versionName "1.0"

        ndk {
@@ -25,6 +21,6 @@ android { 


dependencies {

    //noinspection GradleDynamicVersion

    provided "com.facebook.react:react-native:${_reactNativeVersion}"

    provided "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"

    compile 'com.yqritc:android-scalablevideoview:1.0.4'

}