Unverified Commit 891add63 authored by Laurent Cozic's avatar Laurent Cozic Committed by GitHub
Browse files

Throw an error instead of crashing app when video source is empty 

If an undefined source is accidentally loaded in react-native-video a fatal error SIGABRT will happen and crash the application. This is very difficult to debug since there's apparently no relation between this crash and react-native-video. So this change checks if the URI is empty and, if it is, it throws an error, allowing the user to find out early about the issue.

https://cloud.githubusercontent.com/assets/5795227/20283860/08223ba6-aabb-11e6-9fdc-d12d32b3aa9a.png
parent 4424774c

Video.js

+2 −0
Changes for Video.js: 2 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -220,6 +220,8 @@ export default class Video extends Component { 
      uri = `file://${uri}`;

    }

    

    if (!uri) throw new Error('Trying to load empty source.');



    const isNetwork = !!(uri && uri.match(/^https?:/));

    const isAsset = !!(uri && uri.match(/^(assets-library|ipod-library|file|content|ms-appx|ms-appdata):/));