Unverified Commit a3732885 authored by Hampton Maxwell's avatar Hampton Maxwell Committed by GitHub
Browse files

Merge pull request #1089 from react-native-community/bugfix/exoplayer-progress-playable 

ExoPlayer playableDuration incorrect
parents 4d2c39ea 9c0ddde1

README.md

+22 −4
Changes for README.md: 22 added lines, 4 removed lines.
Original line number Diff line number Diff line
@@ -195,7 +195,6 @@ using System.Collections.Generic; 
       onFullscreenPlayerDidPresent={this.fullScreenPlayerDidPresent}   // Callback after fullscreen started

       onFullscreenPlayerWillDismiss={this.fullScreenPlayerWillDismiss} // Callback before fullscreen stops

       onFullscreenPlayerDidDismiss={this.fullScreenPlayerDidDismiss}  // Callback after fullscreen stopped

       onProgress={this.setTime}               // Callback every ~250ms with currentTime

       style={styles.backgroundVideo} />



// Later to trigger fullscreen
@@ -242,6 +241,7 @@ var styles = StyleSheet.create({ 
### Event props

* [onLoad](#onload)

* [onLoadStart](#onloadstart)

* [onProgress](#onprogress)

* [onTimedMetadata](#ontimedmetadata)



### Methods
@@ -496,9 +496,9 @@ Payload: 


Property | Description

--- | ---

isNetwork | Boolean indicating if the media is being loaded from the network

type | Type of the media. Not available on Windows

uri | URI for the media source. Not available on Windows

isNetwork | boolean | Boolean indicating if the media is being loaded from the network

type | string | Type of the media. Not available on Windows

uri | string | URI for the media source. Not available on Windows



Example:

```
@@ -511,6 +511,24 @@ Example: 


Platforms: all



#### onProgress

Callback function that is called every progressInterval seconds with info about which position the media is currently playing.



Property | Description

--- | ---

currentTime | number | Current position in seconds

playableDuration | number | Position to where the media can be played to using just the buffer in seconds

seekableDuration | number | Position to where the media can be seeked to in seconds. Typically, the total length of the media



Example:

```

{

  currentTime: 5.2,

  playableDuration: 34.6,

  seekableDuration: 888

}

```



#### onTimedMetadata

Callback function that is called when timed metadata becomes available

android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java

+1 −1
Changes for android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ class ReactExoplayerView extends FrameLayout implements 
                            && player.getPlayWhenReady()

                            ) {

                        long pos = player.getCurrentPosition();

                        long bufferedDuration = player.getBufferedPercentage() * player.getDuration();

                        long bufferedDuration = player.getBufferedPercentage() * player.getDuration() / 100;

                        eventEmitter.progressChanged(pos, bufferedDuration, player.getDuration());

                        msg = obtainMessage(SHOW_PROGRESS);

                        sendMessageDelayed(msg, Math.round(mProgressUpdateInterval));