Commit d7c44104 authored by Hampton Maxwell's avatar Hampton Maxwell
Browse files

Catch exception when setting the rate on some devices 

A more elegant fix would be nice but is more work than it's worth at this time.
parent 16fac563

android/src/main/java/com/brentvatne/react/ReactVideoView.java

+8 −0
Changes for android/src/main/java/com/brentvatne/react/ReactVideoView.java: 8 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -410,8 +410,16 @@ public class ReactVideoView extends ScalableVideoView implements MediaPlayer.OnP 
        if (mMediaPlayerValid) {

            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {

                if (!mPaused) { // Applying the rate while paused will cause the video to start

                    /* Per https://stackoverflow.com/questions/39442522/setplaybackparams-causes-illegalstateexception

                     * Some devices throw an IllegalStateException if you set the rate without first calling reset()

                     * TODO: Call reset() then reinitialize the player

                     */

                    try {

                        mMediaPlayer.setPlaybackParams(mMediaPlayer.getPlaybackParams().setSpeed(rate));

                        mActiveRate = rate;

                    } catch (Exception e) {

                        Log.e(ReactVideoViewManager.REACT_CLASS, "Unable to set rate, unsupported on this device");

                    }

                }

            } else {

                Log.e(ReactVideoViewManager.REACT_CLASS, "Setting playback rate is not yet supported on Android versions below 6.0");