Commit e05c1c3c authored by Ibrahim Sulaiman's avatar Ibrahim Sulaiman
Browse files

Resolved the review comments

parent 8cffd5bc

README.md

+1 −1
Changes for README.md: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -361,7 +361,7 @@ Note on iOS, controls are always shown when in fullscreen mode. 


Controls are not available Android because the system does not provide a stock set of controls. You will need to build your own or use a package like [react-native-video-controls](https://github.com/itsnubix/react-native-video-controls) or [react-native-video-player](https://github.com/cornedor/react-native-video-player).



Platforms: iOS, Android, react-native-dom

Platforms: iOS, Android ExoPlayer, react-native-dom



#### filter

Add video filter

android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java

+4 −6
Changes for android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java: 4 added lines, 6 removed lines.
Original line number Diff line number Diff line
@@ -64,7 +64,6 @@ import com.google.android.exoplayer2.upstream.BandwidthMeter; 
import com.google.android.exoplayer2.upstream.DefaultBandwidthMeter;

import com.google.android.exoplayer2.util.MimeTypes;

import com.google.android.exoplayer2.util.Util;

//Import PlayerControlView

import com.google.android.exoplayer2.ui.PlayerControlView;



import java.net.CookieHandler;
@@ -98,7 +97,6 @@ class ReactExoplayerView extends FrameLayout implements 
    }



    private final VideoEventEmitter eventEmitter;

    //Create playerControlView instance

    private PlayerControlView playerControlView;

    

    private Handler mainHandler;
@@ -274,9 +272,9 @@ class ReactExoplayerView extends FrameLayout implements 
    }



    /**

     * Initialising Player control

     * Initializing Player control

     */

    private void initialisePlayerControl() {

    private void initializePlayerControl() {

        playerControlView = new PlayerControlView(getContext());

        LayoutParams layoutParams = new LayoutParams(

                LayoutParams.MATCH_PARENT,
@@ -1107,8 +1105,8 @@ class ReactExoplayerView extends FrameLayout implements 
     */

    public void setControls(boolean controls) {

        if(controls && (exoPlayerView != null)) {

            //Initialise playerControlView

            initialisePlayerControl();

            //Initialize playerControlView

            initializePlayerControl();

        }

    }

}