Commit 593ace35 authored by Francesco Degrassi's avatar Francesco Degrassi
Browse files

Avoid breaking cordova-plugin-local-notifications 

Conflicting implementation of didRegisterUserNotificationSettings
prevents cordova-local-notifications-plugin from being notified of success.
emoving it fixes the problem as it was redundant (simply calls
registerForRemoteNotifications, which is called anyway from PushPlugin:init
right after registerUserNotificationSettings).

Fixes phonegap/phonegap-plugin-push/issues/183 and
katzer/cordova-plugin-local-notifications/issues/695
parent cea75bba

src/ios/AppDelegate+notification.h

+0 −1
Original line number Diff line number Diff line
@@ -13,7 +13,6 @@ 
- (void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error;

- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo;

- (void)applicationDidBecomeActive:(UIApplication *)application;

- (void)application:(UIApplication *)application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings;

- (void)application:(UIApplication *)application handleActionWithIdentifier:(NSString *)identifier forRemoteNotification:(NSDictionary *)userInfo completionHandler:(void(^)())completionHandler;

- (id) getCommandInstance:(NSString*)className;

src/ios/AppDelegate+notification.m

+0 −6
Original line number Diff line number Diff line
@@ -98,12 +98,6 @@ static char launchNotificationKey; 
    }

}



- (void)application:(UIApplication *)application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings

{

    //register to receive notifications

    [application registerForRemoteNotifications];

}



//For interactive notification only

- (void)application:(UIApplication *)application handleActionWithIdentifier:(NSString *)identifier forRemoteNotification:(NSDictionary *)userInfo completionHandler:(void(^)())completionHandler

{