Skip to content
  1. Mar 07, 2016
    • Simon MacDonald's avatar
      9e3b843c
    • tommy-carlos williams's avatar
      [ios] better swizzling · b494f6bb
      tommy-carlos williams authored
      This still isn't the "right way" linked in #427, but seems to be safe
      and void of side effects due to the namespacing of all the methods.
      
      It has been tested to work side by side with another plugin that also
      swizzles AppDelegate's applicationDidBecomeActive.
      
      1. wrapped swizzling in dispatch_once
      2. first attempts class_addMethod / class_replaceMethod but if that
      fails falls back to method_exchangeImplementations.
      3. swizzled_init => pushPluginSwizzledInit (if other plugins attempt to
      swizzle init and use the same name, there seems to be a collision)
      4. added an observer for UIApplicationDidBecomeActiveNotification
      instead of overriding applicationDidBecomeActive
      5. applicationDidBecomeActive => pushPluginOnApplicationDidBecomeActive
      (and it becomes a notification observer instead)
      
      See http://nshipster.com/method-swizzling/ and "Avoid collisions" under
      "Considerations".
      
      This will need testng by someone that understands the plugin better than
      I do, but it should not be changing the core functionality at all. The
      pushPluginOnApplicationDidBecomeActive method *is* called when the
      application becomes active, etc.
      
      Goes a long way toward fixing #427 without regressing #447, etc.
      b494f6bb
    • Simon MacDonald's avatar
      Create PULL_REQUEST_TEMPLATE.md · c6dd84f5
      Simon MacDonald authored
      c6dd84f5
  2. Feb 29, 2016
  3. Feb 18, 2016
  4. Feb 16, 2016
  5. Feb 05, 2016
  6. Feb 04, 2016
  7. Feb 03, 2016
  8. Feb 02, 2016
  9. Jan 27, 2016
  10. Jan 14, 2016
  11. Jan 13, 2016
  12. Jan 12, 2016
  13. Jan 06, 2016
  14. Jan 05, 2016
  15. Dec 31, 2015
  16. Dec 21, 2015
  17. Dec 18, 2015